xfs
[Top] [All Lists]

Re: [PATCH 4/7] xfs: split direct IO write path from xfs_file_aio_write

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/7] xfs: split direct IO write path from xfs_file_aio_write
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 20 Dec 2010 06:29:47 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20101217073125.GE5193@dastard>
References: <1292376208-16282-1-git-send-email-david@xxxxxxxxxxxxx> <1292376208-16282-5-git-send-email-david@xxxxxxxxxxxxx> <20101216120629.GC20445@xxxxxxxxxxxxx> <20101217073125.GE5193@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Dec 17, 2010 at 06:31:25PM +1100, Dave Chinner wrote:
> > Speaking of that, shouldn't xfs_file_aio_read also take the iolock
> > exclusive during the page invalidation and then demote it, just like
> > the write case?  The above helpers would enforce that nicely.
> 
> Probably, though it might be best to leave that to another cleanup
> series. I'll see how much perturbation of the read path it makes....

Yes, it should be a separate patch for sure.  If you prefer another
series that's fine with me, too.

<Prev in Thread] Current Thread [Next in Thread>