xfs
[Top] [All Lists]

Re: [PATCH 9/9] xfs: use AIL bulk delete function to implement single de

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 9/9] xfs: use AIL bulk delete function to implement single delete
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 17 Dec 2010 09:16:33 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1292214743-18073-10-git-send-email-david@xxxxxxxxxxxxx>
References: <1292214743-18073-1-git-send-email-david@xxxxxxxxxxxxx> <1292214743-18073-10-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 13, 2010 at 03:32:23PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> We now have two copies of AIL delete operations that are mostly
> duplicate functionality. The single log item deletes can be
> implemented via the bulk updates by turning xfs_trans_ail_delete()
> into a simple wrapper. This removes all the duplicate delete
> functionality and associated helpers.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

The same comment about just taking the address as for the previous patch
applies.

<Prev in Thread] Current Thread [Next in Thread>