Re: [PATCH 4/9] xfs: bulk AIL insertion during transaction commit

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Minor style nipicks below:

> +                     /*
> +                      * Not a bulk update option due to unusual item_lsn.
> +                      * Push into AIL immediately, rechecking the lsn once
> +                      * we have the ail lock. Then unpin the item.
> +                      */
> +                     spin_lock(&ailp->xa_lock);
> +                     if (XFS_LSN_CMP(item_lsn, lip->li_lsn) > 0) {
> +                             xfs_trans_ail_update(ailp, lip, item_lsn);
> +                     } else {
> +                             spin_unlock(&ailp->xa_lock);
> +                     }

No need for the curly braces.

> +     ASSERT((&next_lip->li_ail == &ailp->xa_ail) ||
> +            (XFS_LSN_CMP(next_lip->li_lsn, lsn) <= 0));

No need for the inner braces.