Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 16 Dec 2010 19:23:07 -0500
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20101216215050.GA5193@dastard>
References:	<1292214743-18073-1-git-send-email-david@xxxxxxxxxxxxx> <1292214743-18073-6-git-send-email-david@xxxxxxxxxxxxx> <20101216153846.GC24185@xxxxxxxxxxxxx> <20101216215050.GA5193@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Dec 17, 2010 at 08:50:50AM +1100, Dave Chinner wrote:
> What tests?

I couldn't really see a pattern yet - it's different ones and different
amount of warnings during each run.

> So this is saying is that a 20ms uninterruptible sleep lasting for more
> than 120s? Doesn't that imply some kind of scheduler starvation, not
> an actual XFS problem?

It does for sure look odd to me.  I'll do a sub-commit bisect between
the two hunk in the patch tomorrow to drill a bit deeper into what's
going on.

<Prev in Thread]	Current Thread	[Next in Thread>
xfs: AIL lock contention reduction V3, Dave Chinner [PATCH 5/9] xfs: reduce the number of AIL push wakeups, Dave Chinner Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups, Christoph Hellwig Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups, Dave Chinner Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups, Christoph Hellwig <= [PATCH 9/9] xfs: use AIL bulk delete function to implement single delete, Dave Chinner Re: [PATCH 9/9] xfs: use AIL bulk delete function to implement single delete, Christoph Hellwig [PATCH 3/9] xfs: clean up xfs_ail_delete(), Dave Chinner [PATCH 1/9] xfs: fix EFI transaction cancellation., Dave Chinner Re: [PATCH 1/9] xfs: fix EFI transaction cancellation., Christoph Hellwig [PATCH 4/9] xfs: bulk AIL insertion during transaction commit, Dave Chinner Re: [PATCH 4/9] xfs: bulk AIL insertion during transaction commit, Christoph Hellwig [PATCH 7/9] xfs: remove all the inodes on a buffer from the AIL in bulk, Dave Chinner Re: [PATCH 7/9] xfs: remove all the inodes on a buffer from the AIL in bulk, Christoph Hellwig [PATCH 2/9] xfs: Pull EFI/EFD handling out from under the AIL lock, Dave Chinner

Previous by Date:	Re: [PATCH 1/7] xfs: ensure sync write errors are returned, Dave Chinner
Next by Date:	Re: [PATCH 1/7] xfs: ensure sync write errors are returned, Dave Chinner
Previous by Thread:	Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups, Dave Chinner
Next by Thread:	[PATCH 9/9] xfs: use AIL bulk delete function to implement single delete, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]