[Top] [All Lists]

Re: [PATCH 3/3] xfs: demultiplex xfs_icsb_modify_counters()

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfs: demultiplex xfs_icsb_modify_counters()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 16 Dec 2010 10:38:26 -0500
Cc: xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, a.p.zijlstra@xxxxxxxxx
In-reply-to: <1292203313-15570-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1292203313-15570-1-git-send-email-david@xxxxxxxxxxxxx> <1292203313-15570-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 13, 2010 at 12:21:53PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> With the conversion to percpu counters, xfs_icsb_modify_counters() really does
> not need to exist. Convert the inode counter modifications to use a common
> helper function for the one place that calls them, and add another function 
> for
> the free block modification and convert all the callers to use that.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>