Re: [PATCH] xfs: log timestamp changes to the source inode in rename

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Tue, Dec 07, 2010 at 05:16:41AM -0500, Christoph Hellwig wrote:
> Now that we don't mark VFS inodes dirty anymore for internal timestamp 
> changes,
> but rely on the transaction subsystem to push them out, we need to explicitly
> log the source inode in rename after updating it's timestamps to make sure
> the changes actually get forced out by sync/fsync or an AIL push.
> 
> We already account for the fourth inode in the log reservation, as a rename
> of directories needs to update the nlink field, so just adding the
> xfs_trans_log_inode call is enough.
> 
> This fixes the xfsqa 065 regression introduced by:
> 
>       "xfs: don't use vfs writeback for pure metadata modifications"
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx