xfs
[Top] [All Lists]

Re: [PATCH 7/8] xfs: use AIL bulk update function to implement single up

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/8] xfs: use AIL bulk update function to implement single updates
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 6 Dec 2010 09:35:45 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1290993152-20999-8-git-send-email-david@xxxxxxxxxxxxx>
References: <1290993152-20999-1-git-send-email-david@xxxxxxxxxxxxx> <1290993152-20999-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 29, 2010 at 12:12:31PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> We now have two copies of AIL insert operations that are mostly
> duplicate functionality. The single log item updates can be
> implemented via the bulk updates by turning xfs_trans_ail_update()
> into a simple wrapper. This removes all the duplicate insert
> functionality and associated helpers.

Looks good, although the comment above xfs_trans_ail_update_bulk,
stating it's the bulk version of xfs_trans_ail_update isn't too
helpful any more after this patch.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 7/8] xfs: use AIL bulk update function to implement single updates, Christoph Hellwig <=