xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfs: remove all the inodes on a buffer from the AIL in b

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/8] xfs: remove all the inodes on a buffer from the AIL in bulk
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 6 Dec 2010 09:33:08 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1290993152-20999-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1290993152-20999-1-git-send-email-david@xxxxxxxxxxxxx> <1290993152-20999-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
While the patch looks good for the ail lock contetion removal, I don't
quite like the model with the double iteration over the log item list
on the buffer.  What do you think about the following plan:

 (1) merge xfs_istale_done into xfs_iflush_done by checking for
     XFS_ISTALE
 (2) convert not only the inode log item completion to your new scheme,
     but also the dquots
 (3) replace xfs_buf_do_callbacks with a callback in the buffer, which
     now points to the inode and dqout routines, or calls the completion
     for the only items in "normal" buf items.

<Prev in Thread] Current Thread [Next in Thread>