xfs
[Top] [All Lists]

Re: [PATCH 02/14] xfs: clean up log space grant functions

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/14] xfs: clean up log space grant functions
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 3 Dec 2010 17:45:48 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101202114049.GB21365@xxxxxxxxxxxxx>
References: <1290994712-21376-1-git-send-email-david@xxxxxxxxxxxxx> <1290994712-21376-3-git-send-email-david@xxxxxxxxxxxxx> <20101201123032.GA20378@xxxxxxxxxxxxx> <20101202014833.GN16922@dastard> <20101202114049.GB21365@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Dec 02, 2010 at 06:40:50AM -0500, Christoph Hellwig wrote:
> On Thu, Dec 02, 2010 at 12:48:33PM +1100, Dave Chinner wrote:
> > Ok, so your main objection is the needless addition to the queue?
> > That can be avoided easily enough via a local variable. Would that
> > be sufficient to alleviate your concerns?
> 
> The main objection is that the new code might be a bit shorted,
> but is a lot less readable.  If you really want it go with it and
> an updated changelog mentioning the behaviour change, but I don't
> really feel too good about it.

OK, I'll drop it.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>