xfs
[Top] [All Lists]

Re: [PATCH 1/8] xfs: Pull EFI/EFD handling out from under the AIL lock

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/8] xfs: Pull EFI/EFD handling out from under the AIL lock
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 2 Dec 2010 06:38:49 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20101202012841.GL16922@dastard>
References: <1290993152-20999-1-git-send-email-david@xxxxxxxxxxxxx> <1290993152-20999-2-git-send-email-david@xxxxxxxxxxxxx> <20101130201734.GA16079@xxxxxxxxxxxxx> <20101202012841.GL16922@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Dec 02, 2010 at 12:28:41PM +1100, Dave Chinner wrote:
> >  - there is a behaviour change about the xfs_trans_del_item call
> >    in xfs_efi_item_unpin - before it was protected by the
> >    XFS_EFI_CANCELED which was never set, and now it's not.
> 
> XFS_EFI_CANCELED has not been set in the code base since
> xfs_efi_cancel() was removed back in 2006 by commit
> 065d312e15902976d256ddaf396a7950ec0350a8 ("[XFS] Remove unused
> iop_abort log item operation), and even then xfs_efi_cancel() was
> never called. I haven't tracked it back further than that (beyond
> git history), but handling of efis in cancelled transactions has
> been broken for a long time.
> 
> Basically, when we get an IOP_UNPIN(lip, 1); call from
> xfs_trans_uncommit() (i.e. remove == 1), if we don't free the log
> item descriptor we leak it. IOWs, the new behaviour introduced in
> this patch is actually the correct behaviour.

Maybe fix this issue first in a separate patch, instead of hiding it
in a bigger one.

<Prev in Thread] Current Thread [Next in Thread>