[Top] [All Lists]

Re: xfstests 065 failures

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: xfstests 065 failures
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 2 Dec 2010 13:21:16 +1100
Cc: dchinner@xxxxxxxxxx, XFS Mailing List <xfs@xxxxxxxxxxx>
In-reply-to: <1291235379.2556.28.camel@doink>
References: <1291235379.2556.28.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Dec 01, 2010 at 02:29:39PM -0600, Alex Elder wrote:
> Dave, you were asking on IRC about test 065 failures.
> I asked Bill Kendall about it and he bisected to find
> that the commit below seems to be where the problems
> started.  I believe the problem is that one of the
> times is not updated properly when renaming the file
> "addedfile4".  Here are the commands that might affect
> that file in test 065:
>       mv addeddir4/addedfile5 addeddir4/addedfile4
>       mv addeddir4 addeddir6
> I glanced at the commit and saw nothing obviously
> wrong, but at the moment I can't really dig into
> it any deeper so I thought I'd report what Bill
> found so others could look.

Yeah, I know that this patch was the cause, and IIRC it only affects
a hard linked directory. What I found is that the iterative dump
actually contains all the correct changes (the restore part of the
test does not fail) - it's just that the dump image table of
contents does not contain the all the changes. I haven't tracked
down why the dump TOC does not contain a modification that is
actually in the dump yet....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>