xfs
[Top] [All Lists]

Re: [PATCH 03/14] xfs: convert log grant heads to LSN notation

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 03/14] xfs: convert log grant heads to LSN notation
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 2 Dec 2010 12:49:28 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101201124234.GB612@xxxxxxxxxxxxx>
References: <1290994712-21376-1-git-send-email-david@xxxxxxxxxxxxx> <1290994712-21376-4-git-send-email-david@xxxxxxxxxxxxx> <20101201124234.GB612@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Dec 01, 2010 at 07:42:35AM -0500, Christoph Hellwig wrote:
> The patch looks good to me, but I really hate overloading the lsn types
> and helpers.  Just add duplicated of CYCLE_LSN/BLOCK_LSN and
> xlog_assign_lsn for a new type as use them.

Ok, will fix.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>