[Top] [All Lists]

Re: [PATCH 10/10] xfs: simplify xfs_map_at_offset

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 10/10] xfs: simplify xfs_map_at_offset
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 1 Dec 2010 15:50:06 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101122130904.961028436@xxxxxxxxxxxxxxxxxxxxxx>
References: <20101122130506.868076797@xxxxxxxxxxxxxxxxxxxxxx> <20101122130904.961028436@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Nov 22, 2010 at 08:05:16AM -0500, Christoph Hellwig wrote:
> Move the buffer locking into the callers as they need to do it wether they
> call xfs_map_at_offset or not.  Remove the b_bdev assignment, which is
> already done by get_blocks.  Remove the duplicate extent type asserts in
> xfs_convert_page just before calling xfs_map_at_offset.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>