[Top] [All Lists]

Re: [PATCH 09/10] xfs: refactor xfs_vm_writepage

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 09/10] xfs: refactor xfs_vm_writepage
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 1 Dec 2010 15:49:13 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101122130904.770817106@xxxxxxxxxxxxxxxxxxxxxx>
References: <20101122130506.868076797@xxxxxxxxxxxxxxxxxxxxxx> <20101122130904.770817106@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Nov 22, 2010 at 08:05:15AM -0500, Christoph Hellwig wrote:
> After the last patches the code for overwrites is the same as for
> delayed and unwritten extents except that it doesn't need to call
> xfs_map_at_offset.  Take care of that fact to simplify xfs_vm_writepage.
> The buffer loop now first checks the type of buffer and checks/sets
> the ioend type, or continues to the next buffer if it's not interesting
> to us.  Only after that we validate the iomap and perform the block
> mapping if needed, all in common code for the cases where we have to
> do work.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Much neater and easier to understand.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>