| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 04/10] xfs: cleanup the xfs_iomap_write_* helpers |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 1 Dec 2010 15:11:02 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20101122130903.730638974@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20101122130506.868076797@xxxxxxxxxxxxxxxxxxxxxx> <20101122130903.730638974@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Mon, Nov 22, 2010 at 08:05:10AM -0500, Christoph Hellwig wrote: > Remove passing the BMAPI_* flags to these helpers, in xfs_iomap_write_direct > the check BMAPI_DIRECT was always true, and in the xfs_iomap_write_delay > path is was never checked at all. Remove the nmap return value as > we never make use of it. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Makes sense - fewer useless parameters being passed around is good... Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 03/10] xfs: a few small tweaks for overwrites in xfs_vm_writepage, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 05/10] xfs: kill xfs_iomap, Dave Chinner |
| Previous by Thread: | [PATCH 04/10] xfs: cleanup the xfs_iomap_write_* helpers, Christoph Hellwig |
| Next by Thread: | [PATCH 06/10] xfs: simplify xfs_map_blocks, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |