xfs
[Top] [All Lists]

Re: [PATCH 2/8] xfs: clean up xfs_ail_delete()

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/8] xfs: clean up xfs_ail_delete()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 30 Nov 2010 15:19:13 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1290993152-20999-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1290993152-20999-1-git-send-email-david@xxxxxxxxxxxxx> <1290993152-20999-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 29, 2010 at 12:12:26PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_ail_delete() has a needlessly complex interface. It returns the log item
> that was passed in for deletion (which the callers then assert is identical to
> the one passed in), and callers of xfs_ail_delete() still need to invalidate
> current traversal cursors.
> 
> Make xfs_ail_delete() return void, move the cursor invalidation inside it, and
> clean up the callers just to use the log item pointer they passed in.
> 
> While cleaning up, remove the messy and unnecessary "/* ARGUSED */" comments
> around all these functions.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>