xfs
[Top] [All Lists]

xfstests: getfacl -n unsupported in older acl package

To: xfs@xxxxxxxxxxx
Subject: xfstests: getfacl -n unsupported in older acl package
From: Boris Ranto <branto@xxxxxxxxxx>
Date: Tue, 30 Nov 2010 14:47:38 +0100
Test cases 051 and 067 use getfacl with option -n. This works well on newer 
systems but older acl package know only its longer version: --numeric.

I've tested the two tests with long option and they both passed.

Therefore I'd propose this patch to fix this for earlier acl versions:

diff -uprN /var/lib/xfstests-orig/051 /var/lib/xfstests/051
--- /var/lib/xfstests-orig/051  2010-11-30 08:29:36.000000000 -0500
+++ /var/lib/xfstests/051       2010-11-30 08:28:18.000000000 -0500
@@ -343,23 +343,23 @@ acl5=`_create_n_aces 17` # 1 over A.G. l
 
 echo "1 below xfs acl max"
 chacl $acl1 largeaclfile
-getfacl -n largeaclfile | _filter_aces
+getfacl --numeric largeaclfile | _filter_aces
 
 echo "xfs acl max"
 chacl $acl2 largeaclfile
-getfacl -n largeaclfile | _filter_aces
+getfacl --numeric largeaclfile | _filter_aces
 
 echo "1 above xfs acl max"
 chacl $acl3 largeaclfile
-getfacl -n largeaclfile | _filter_aces
+getfacl --numeric largeaclfile | _filter_aces
 
 echo "use 16 aces"
 chacl $acl4 largeaclfile
-getfacl -n largeaclfile | _filter_aces
+getfacl --numeric largeaclfile | _filter_aces
 
 echo "use 17 aces"
 chacl $acl5 largeaclfile
-getfacl -n largeaclfile | _filter_aces
+getfacl --numeric largeaclfile | _filter_aces
 
 #-------------------------------------------------------
 
diff -uprN /var/lib/xfstests-orig/067 /var/lib/xfstests/067
--- /var/lib/xfstests-orig/067  2010-11-30 08:29:10.000000000 -0500
+++ /var/lib/xfstests/067       2010-11-30 08:31:28.000000000 -0500
@@ -73,19 +73,19 @@ acl21=`_create_n_aces 21`
 
 echo "try 20 aces for access acl"
 chacl $acl20 largeacldir
-getfacl -n largeacldir | _filter_aces
+getfacl --numeric largeacldir | _filter_aces
 
 echo "try 20 aces for default acl"
 chacl -d $acl20 largeacldir
-getfacl -n largeacldir | _filter_aces
+getfacl --numeric largeacldir | _filter_aces
 
 echo "try 21 aces for access acl"
 chacl $acl21 largeacldir
-getfacl -n largeacldir | _filter_aces
+getfacl --numeric largeacldir | _filter_aces
 
 echo "try 21 aces for default acl"
 chacl -d $acl21 largeacldir
-getfacl -n largeacldir | _filter_aces
+getfacl --numeric largeacldir | _filter_aces
 
 # success, all done
 status=0

Signed-off-by: Boris Ranto <branto@xxxxxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>