xfs
[Top] [All Lists]

Re: [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 29 Nov 2010 14:42:10 -0600
Cc: Bill Kendall <wkendall@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20101129145627.GB22839@xxxxxxxxxxxxx>
References: <20101119183837.GA9505@xxxxxxx> <20101123134818.GA31206@xxxxxxxxxxxxx> <4CF3B875.3020701@xxxxxxx> <20101129145627.GB22839@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Mon, 2010-11-29 at 09:56 -0500, Christoph Hellwig wrote:
> On Mon, Nov 29, 2010 at 08:28:05AM -0600, Bill Kendall wrote:
> > There are several modules in xfsrestore which map files. None of them
> > currently contain a destructor/cleanup function for unmapping the files.
> > It would be a good change to make though.
> 
> If keeping it mapped later it's fine with me.  So ACK from me for the
> whole series.
> 
> Alex, maybe it's time to push out another xfsdump release after this?
> There's quite a few changes that have accumulated.

Yes, I had planned to do that once we got Bill's series
committed.  I am doing a final test of it today before
pushing it to the -dev tree, for starters.

I also wanted to update my metadump series and, after
getting that committed, mark a new release for xfsprogs
as well.  I thought I'd do these releases at the same
time but I guess they don't have to be.

                                        -Alex


<Prev in Thread] Current Thread [Next in Thread>