xfs
[Top] [All Lists]

Re: [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 29 Nov 2010 09:56:27 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4CF3B875.3020701@xxxxxxx>
References: <20101119183837.GA9505@xxxxxxx> <20101123134818.GA31206@xxxxxxxxxxxxx> <4CF3B875.3020701@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 29, 2010 at 08:28:05AM -0600, Bill Kendall wrote:
> There are several modules in xfsrestore which map files. None of them
> currently contain a destructor/cleanup function for unmapping the files.
> It would be a good change to make though.

If keeping it mapped later it's fine with me.  So ACK from me for the
whole series.

Alex, maybe it's time to push out another xfsdump release after this?
There's quite a few changes that have accumulated.

<Prev in Thread] Current Thread [Next in Thread>