xfs
[Top] [All Lists]

Re: [PATCH 1/3] lib: percpu counter add unless less than functionality

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] lib: percpu counter add unless less than functionality
From: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Date: Mon, 29 Nov 2010 13:08:50 +0100
Cc: xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1290991002-18680-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1290991002-18680-1-git-send-email-david@xxxxxxxxxxxxx> <1290991002-18680-2-git-send-email-david@xxxxxxxxxxxxx>
On Mon, 2010-11-29 at 11:36 +1100, Dave Chinner wrote:
> +int percpu_counter_add_unless_lt(struct percpu_counter *fbc, s64 amount,
> +                                                       s64 threshold);

It might make sense to implement that as;

  __percpu_counter_add_unless_lt(struct percpu_counter *fbc,
                                 s64 amount,
                                 s64 threshold,
                                 s32 batch);

That way its consistent with the __percpu_counter_add() implementation
where you can also specify the batch value.


<Prev in Thread] Current Thread [Next in Thread>