xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: don't truncate prealloc from frequently accessed in

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: don't truncate prealloc from frequently accessed inodes
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Mon, 29 Nov 2010 10:42:29 +0100
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <1290991431-20519-3-git-send-email-david@xxxxxxxxxxxxx> (Dave Chinner's message of "Mon, 29 Nov 2010 11:43:51 +1100")
References: <1290991431-20519-1-git-send-email-david@xxxxxxxxxxxxx> <1290991431-20519-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
Dave Chinner <david@xxxxxxxxxxxxx> writes:
>
> To avoid this problem, keep a count of the number of ->release calls
> made on an inode. For most cases, an inode is only going to be opened
> once for writing and then closed again during it's lifetime in
> cache. Hence if there are multiple ->release calls, there is a good
> chance that the inode is being accessed by the NFS server. Hence
> count up every time ->release is called while there are delalloc
> blocks still outstanding on the inode.

Seems like a hack. It would be cleaner and less fragile to add a
explicit VFS hint that is passed down from the nfs server, similar
to the existing open intents.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.

<Prev in Thread] Current Thread [Next in Thread>