[Top] [All Lists]

Re: XFS reclaim lock order bug

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: XFS reclaim lock order bug
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 24 Nov 2010 15:03:41 -0500
Cc: Nick Piggin <npiggin@xxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20101123211258.GY22876@dastard>
References: <20101123121802.GA4785@amd> <20101123211258.GY22876@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 24, 2010 at 08:12:58AM +1100, Dave Chinner wrote:
> It is supposed to be handled by the re-initialisation of the
> ip->i_iolock in ->evict_inode (xfs_fs_evict_inode). An inode found
> in the reclaim state must have passed through this reinitialisation,
> so from a lockdep perspective the iolock in the vfs path is a
> different context to the iolock in the reclaim path. That fixed all
> the non-reclaim state related lockdep false positives, so Perhaps
> there is an issue with the lockdep reclaim state checking that does
> not interact well with re-initialised lock contexts?

I've been looking through this again, and I think it's indeed not
enough.  We don't just need to re-initialize it, but also set a
different lockclass for it.

<Prev in Thread] Current Thread [Next in Thread>