[Top] [All Lists]

Re: [PATCH] xfs: fix exporting with left over 64-bit inodes

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix exporting with left over 64-bit inodes
From: Samuel Kvasnica <samuel.kvasnica@xxxxxxxxx>
Date: Mon, 22 Nov 2010 10:05:27 +0100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20101122003754.GE13830@dastard>
Organization: IMS Nanofabrication AG
References: <20101119133848.GA5471@xxxxxxxxxxxxx>
References: <20101122003754.GE13830@dastard>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101026 SUSE/3.1.6 Lightning/1.0b2 Thunderbird/3.1.6
On 11/22/2010 01:37 AM, Dave Chinner wrote:
> On Fri, Nov 19, 2010 at 08:38:49AM -0500, Christoph Hellwig wrote:
>> From: Samuel Kvasnica <samuel.kvasnica@xxxxxxxxx>
>> We now support mounting and using filesystems with 64-bit inodes even
>> when not mounted with the inode64 option (which now only controls if
>> we allocate new inodes in that space or not).  Make sure we always
>> use large NFS file handles when exporting a filesystem that may contain
>> 64-bit inodes.  Note that this only affects newly generated file handles,
>> any outstanding 32-bit file handle is still accepted.
>> [hch: the comment and commit log are mine, the rest is from a patch
>>  snipplet from Samuel]
>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Won't this mean that people exporting non-root directories suddenly
> have those exports stop working on a kernel upgrade due to changing
> the handle format?
> Cheers,
> Dave.
Hello Dave,

nothing is really changing, it is a bugfix. NFS was trying to use 32bit
inodes which was incorrect (i.e. broken at client) for xfs filesystem
containing 64bit inodes in one special case. This is fixed now.



<Prev in Thread] Current Thread [Next in Thread>