xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add test for fallocate with hole punching

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add test for fallocate with hole punching
From: Josef Bacik <josef@xxxxxxxxxx>
Date: Thu, 18 Nov 2010 03:32:19 -0500
Cc: Josef Bacik <josef@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20101118053052.GT13830@dastard>
References: <1289598949-19216-1-git-send-email-josef@xxxxxxxxxx> <20101118053052.GT13830@dastard>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Nov 18, 2010 at 04:30:52PM +1100, Dave Chinner wrote:
> On Fri, Nov 12, 2010 at 04:55:49PM -0500, Josef Bacik wrote:
> > This test is based on 242, just modified to use fiemap, fallocate and 
> > fallocate
> > -p.  I've looked at all of the output by hand and verified that it's working
> > properly.  Thanks,
> > 
> > Signed-off-by: Josef Bacik <josef@xxxxxxxxxx>
> > ---
> >  245       |  189 
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  245.out   |   47 +++++++++++++++
> >  common.rc |   27 +++++++++
> >  group     |    1 +
> >  4 files changed, 264 insertions(+), 0 deletions(-)
> >  create mode 100755 245
> >  create mode 100644 245.out
> > 
> > diff --git a/245 b/245
> > new file mode 100755
> > index 0000000..6f7a502
> > --- /dev/null
> > +++ b/245
> > @@ -0,0 +1,189 @@
> > +#! /bin/bash
> > +# FS QA Test No. 242
> 
> Not test 242 anymore...
> 
> > +#
> > +# Test XFS_IOC_ZERO_RANGE
> 
> Nor that. ;)
>

Crap what the hell this is all right in my local copy.  I must have forgotten
to commit my changes.
 
> > +#
> > +#-----------------------------------------------------------------------
> > +# Copyright (c) 2010 Red Hat.  All Rights Reserved.
> > +#
> > +# This program is free software; you can redistribute it and/or
> > +# modify it under the terms of the GNU General Public License as
> > +# published by the Free Software Foundation.
> > +#
> > +# This program is distributed in the hope that it would be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +# GNU General Public License for more details.
> > +#
> > +# You should have received a copy of the GNU General Public License
> > +# along with this program; if not, write the Free Software Foundation,
> > +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> > +#
> > +#-----------------------------------------------------------------------
> > +#
> > +# creator
> > +owner=dchinner@xxxxxxxxxx
> 
> Not me ;)
> 
> > +
> > +seq=`basename $0`
> > +echo "QA output created by $seq"
> > +
> > +here=`pwd`
> > +tmp=/tmp/$$
> > +status=1   # failure is the default!
> > +
> > +_cleanup()
> > +{
> > +    rm -f $tmp.*
> > +}
> > +
> > +trap "_cleanup ; exit \$status" 0 1 2 3 15
> > +
> > +# get standard environment, filters and checks
> > +. ./common.rc
> > +. ./common.filter
> > +
> > +# real QA test starts here
> > +_supported_fs generic
> > +_supported_os Linux
> > +
> > +_require_xfs_io_falloc_punch
> > +_require_xfs_io_fiemap
> > +
> > +_filter_bmap()
> > +{
> > +    awk --posix '$3 ~ /hole/ { print $1, $2, $3; next }
> > +            $5 ~ /0x[[:digit:]]*8[[:digit:]]{2}/ { print $1, $2, 
> > "unwritten"; next }
> > +            $5 ~ /0x[[:digit:]]+/ {print $1, $2, "data" }'
> > +}
> > +
> > +# test the different corner cases for falloc -ping a range:
> 
>                                          punching
> 
> > +#
> > +#  1. into a hole
> > +#  2. into allocated space
> > +#  3. into unwritten space
> > +#  4. hole -> data
> > +#  5. hole -> unwritten
> > +#  6. data -> hole
> > +#  7. data -> unwritten
> > +#  8. unwritten -> hole
> > +#  9. unwritten -> data
> > +#  10. hole -> data -> hole
> > +#  11. data -> hole -> data
> > +#  12. unwritten -> data -> unwritten
> > +#  13. data -> unwritten -> data
> > +
> > +testfile=$TEST_DIR/242.$$
>                       ^^^
> 
> > +
> > +echo "     1. into a hole"
> > +rm -f $testfile
> > +$XFS_IO_PROG -F -f -c "truncate 20k" \
> > +   -c "falloc -p 4k 8k" \
> > +   -c "fiemap -v" $testfile | _filter_bmap
> > +[ $? -ne 0 ] && die_now
> 
> This looks almost almost exactly the same test as 242 just with the
> alloc, map and punch commands changed.  I'd suggest making all these
> cases into a function that takes three parameters - alloc_cmd
> punch_cmd and map_cmd - and pulling it into common.punch.
> 

Oh yeah, like I said I just did "cp 242 245" and then changed everything to use
falloc -p instead of zero :).

> e.g. we end up with a function full of commands like:
> 
> $XFS_IO_PROG -F -f -c "truncate 20k" \
>       -c "$punch_cmd 4k 8k" \
>       -c "$map_cmd" $testfile | _filter_bmap
> 
> Which means it can be used for 242, this test, and another test for
> the xfs resvsp/unresvsp ioctls...
> 

Sounds good I can do that.  Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>