xfs
[Top] [All Lists]

Re: [PATCH] xfstests 246: Test for race between direct I/O and mmap

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests 246: Test for race between direct I/O and mmap
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 18 Nov 2010 16:36:23 +1100
Cc: xfs mailing list <xfs@xxxxxxxxxxx>, Lachlan McIlroy <lmcilroy@xxxxxxxxxx>
In-reply-to: <4CDDC193.9030208@xxxxxxxxxx>
References: <4CDDC193.9030208@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Nov 12, 2010 at 04:37:07PM -0600, Eric Sandeen wrote:
> 
> 
> From: Lachlan McIlroy <lmcilory@xxxxxxxxxx>
> 
> A customer reported a problem:
> 
> If a process is using mmap to write to a file on an 
> ext4 filesystem while another process is using direct 
> I/O to write to the same file the first thread may 
> receive a SIGBUS during a page fault.
> 
> A SIGBUS occurs if the page fault tries to access a 
> page that is entirely beyond the end of the file but 
> in this test case that should not be happening.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

looks fine to me.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>