xfs
[Top] [All Lists]

[PATCH 4/6] Ext4: fail if we try to use hole punch

To: david@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cmm@xxxxxxxxxx, cluster-devel@xxxxxxxxxx, joel.becker@xxxxxxxxxx, jack@xxxxxxx
Subject: [PATCH 4/6] Ext4: fail if we try to use hole punch
From: Josef Bacik <josef@xxxxxxxxxx>
Date: Wed, 17 Nov 2010 20:46:18 -0500
In-reply-to: <1290044780-2902-1-git-send-email-josef@xxxxxxxxxx>
References: <1290044780-2902-1-git-send-email-josef@xxxxxxxxxx>
Ext4 doesn't have the ability to punch holes yet, so make sure we return
EOPNOTSUPP if we try to use hole punching through fallocate.  This support can
be added later.  Thanks,

Acked-by: Jan Kara <jack@xxxxxxx>
Signed-off-by: Josef Bacik <josef@xxxxxxxxxx>
---
 fs/ext4/extents.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 0554c48..35bca73 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, 
loff_t offset, loff_t len)
        struct ext4_map_blocks map;
        unsigned int credits, blkbits = inode->i_blkbits;
 
+       /* We only support the FALLOC_FL_KEEP_SIZE mode */
+       if (mode && (mode != FALLOC_FL_KEEP_SIZE))
+               return -EOPNOTSUPP;
+
        /*
         * currently supporting (pre)allocate mode for extent-based
         * files _only_
-- 
1.6.6.1

<Prev in Thread] Current Thread [Next in Thread>