xfs
[Top] [All Lists]

Re: [PATCH 3/6] Ocfs2: handle hole punching via fallocate properly

To: Josef Bacik <josef@xxxxxxxxxx>
Subject: Re: [PATCH 3/6] Ocfs2: handle hole punching via fallocate properly
From: Joel Becker <Joel.Becker@xxxxxxxxxx>
Date: Wed, 17 Nov 2010 15:27:45 -0800
Cc: david@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cmm@xxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
In-reply-to: <1289840723-3056-4-git-send-email-josef@xxxxxxxxxx>
Mail-followup-to: Josef Bacik <josef@xxxxxxxxxx>, david@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cmm@xxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
References: <1289840723-3056-1-git-send-email-josef@xxxxxxxxxx> <1289840723-3056-4-git-send-email-josef@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Nov 15, 2010 at 12:05:20PM -0500, Josef Bacik wrote:
> This patch just makes ocfs2 use its UNRESERVP ioctl when we get the hole punch
> flag in fallocate.  I didn't test it, but it seems simple enough.  Thanks,
> 
> Signed-off-by: Josef Bacik <josef@xxxxxxxxxx>

Seems reasonable to me.
Acked-by: Joel Becker <joel.becker@xxxxxxxxxx>

Joel

> ---
>  fs/ocfs2/file.c |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 77b4c04..181ae52 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -1992,6 +1992,7 @@ static long ocfs2_fallocate(struct inode *inode, int 
> mode, loff_t offset,
>       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
>       struct ocfs2_space_resv sr;
>       int change_size = 1;
> +     int cmd = OCFS2_IOC_RESVSP64;
>  
>       if (!ocfs2_writes_unwritten_extents(osb))
>               return -EOPNOTSUPP;
> @@ -2002,12 +2003,17 @@ static long ocfs2_fallocate(struct inode *inode, int 
> mode, loff_t offset,
>       if (mode & FALLOC_FL_KEEP_SIZE)
>               change_size = 0;
>  
> +     if (mode & FALLOC_FL_PUNCH_HOLE) {
> +             cmd = OCFS2_IOC_UNRESVSP64;
> +             change_size = 0;
> +     }
> +
>       sr.l_whence = 0;
>       sr.l_start = (s64)offset;
>       sr.l_len = (s64)len;
>  
> -     return __ocfs2_change_file_space(NULL, inode, offset,
> -                                      OCFS2_IOC_RESVSP64, &sr, change_size);
> +     return __ocfs2_change_file_space(NULL, inode, offset, cmd, &sr,
> +                                      change_size);
>  }
>  
>  int ocfs2_check_range_for_refcount(struct inode *inode, loff_t pos,
> -- 
> 1.6.6.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 

"Born under a bad sign.
 I been down since I began to crawl.
 If it wasn't for bad luck,
 I wouldn't have no luck at all."

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker@xxxxxxxxxx
Phone: (650) 506-8127

<Prev in Thread] Current Thread [Next in Thread>