xfs
[Top] [All Lists]

Re: [PATCH v3 9/9] xfsrestore: check for compatible xfsrestore

To: wkendall@xxxxxxx
Subject: Re: [PATCH v3 9/9] xfsrestore: check for compatible xfsrestore
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 17 Nov 2010 04:38:42 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101116150705.423217632@xxxxxxx>
References: <20101116150502.179825893@xxxxxxx> <20101116150705.423217632@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 16, 2010 at 09:05:11AM -0600, wkendall@xxxxxxx wrote:
> When resuming a restore or doing a cumulative restore, xfsrestore
> reads state information left around by the previous invocation.
> This patch adds logic to determine whether or not restore is
> able to make sense of the sense information.
> 
> The xfsrestore man page has also been updated to make the user
> aware of the requirement to use a compatible restore and
> system when resuming restores.

Shouldn't you use the opportunity to switch everything in the on-disk
layout to explicitly sized types?  Seeing things like the bool types
in the persistant structures really scares me.

<Prev in Thread] Current Thread [Next in Thread>