[Top] [All Lists]

Re: [PATCH v3 3/9] xfsrestore: cache path lookups

To: wkendall@xxxxxxx
Subject: Re: [PATCH v3 3/9] xfsrestore: cache path lookups
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 17 Nov 2010 04:24:08 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101116150704.237582191@xxxxxxx>
References: <20101116150502.179825893@xxxxxxx> <20101116150704.237582191@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 16, 2010 at 09:05:05AM -0600, wkendall@xxxxxxx wrote:
> In order to resolve a pathname, xfsrestore must work from an inode
> number (from the dump) and recurse up the directory entry tree that it
> has constructed. Each level of recursion requires a seek and read to
> get the name of the dirent, and possibly a mmap of a section of the
> directory entry tree if it is not already mapped (and in that case,
> possibly a munmap of another section). It's quite common to resolve
> pathnames in the same directory consecutively, so simply caching the
> parent directory pathname from the previous lookup saves quite a bit
> of overhead.
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>
> Reviewed-by: Alex Elder <aelder@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>