xfs
[Top] [All Lists]

Re: [PATCH v3 2/9] xfsrestore: change nrh_t from 32 to 64 bits

To: wkendall@xxxxxxx
Subject: Re: [PATCH v3 2/9] xfsrestore: change nrh_t from 32 to 64 bits
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 17 Nov 2010 04:23:22 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101116150703.992326844@xxxxxxx>
References: <20101116150502.179825893@xxxxxxx> <20101116150703.992326844@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 16, 2010 at 09:05:04AM -0600, wkendall@xxxxxxx wrote:
> An nrh_t refers to a byte offset in a file containing all the pathname
> components from a dump. At an average filename length of 20
> characters, an nrh_t would overflow on a dump containing ~214 million
> directory entries. Removing this limitation allows xfsrestore to
> handle 4 billion directory entries.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>