xfs
[Top] [All Lists]

Re: [PATCH v3 7/9] xfsrestore: make node lookup more efficient

To: wkendall@xxxxxxx
Subject: Re: [PATCH v3 7/9] xfsrestore: make node lookup more efficient
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 16 Nov 2010 13:20:07 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101116150705.030079100@xxxxxxx>
References: <20101116150502.179825893@xxxxxxx> <20101116150705.030079100@xxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2010-11-16 at 09:05 -0600, wkendall@xxxxxxx wrote:
> plain text document attachment (window_lookup_performance)
> When converting an nh_t to a segment index and relative node index,
> use shift and bitwise-and instead of division and modulo. Results show
> this is about 50% faster than the current method.

So the mapping interface now takes a segment index
rather than a node index, and you have node_map_*()
functions that operate on node handles.  I think
that's good.  That change seems to be bigger, but
it basically enabled you to make the switch to
masking only affect those new functions.

Anyway, looks good to me.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>