xfs
[Top] [All Lists]

Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

To: Josef Bacik <josef@xxxxxxxxxx>
Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch
From: Avi Kivity <avi@xxxxxxxxxx>
Date: Tue, 16 Nov 2010 15:07:29 +0200
Cc: david@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cmm@xxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
In-reply-to: <20101116125016.GA31957@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1289840723-3056-1-git-send-email-josef@xxxxxxxxxx> <1289840723-3056-5-git-send-email-josef@xxxxxxxxxx> <4CE2783F.1020004@xxxxxxxxxx> <20101116125016.GA31957@xxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6
On 11/16/2010 02:50 PM, Josef Bacik wrote:
On Tue, Nov 16, 2010 at 02:25:35PM +0200, Avi Kivity wrote:
>  On 11/15/2010 07:05 PM, Josef Bacik wrote:
>>  Ext4 doesn't have the ability to punch holes yet, so make sure we return
>>  EOPNOTSUPP if we try to use hole punching through fallocate.  This support 
can
>>  be added later.  Thanks,
>>
>
>  Instead of teaching filesystems to fail if they don't support the
>  capability, why don't supporting filesystems say so, allowing the fail
>  code to be in common code?
>

There is no simple way to test if a filesystem supports hole punching or not so
the check has to be done per fs.  Thanks,

Could put a flag word in superblock_operations. Filesystems which support punching (or other features) can enable it there.

Or even have its own callback.

--
error compiling committee.c: too many arguments to function

<Prev in Thread] Current Thread [Next in Thread>