xfs
[Top] [All Lists]

Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

To: Avi Kivity <avi@xxxxxxxxxx>
Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch
From: Josef Bacik <josef@xxxxxxxxxx>
Date: Tue, 16 Nov 2010 07:50:16 -0500
Cc: Josef Bacik <josef@xxxxxxxxxx>, david@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cmm@xxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
In-reply-to: <4CE2783F.1020004@xxxxxxxxxx>
References: <1289840723-3056-1-git-send-email-josef@xxxxxxxxxx> <1289840723-3056-5-git-send-email-josef@xxxxxxxxxx> <4CE2783F.1020004@xxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Nov 16, 2010 at 02:25:35PM +0200, Avi Kivity wrote:
> On 11/15/2010 07:05 PM, Josef Bacik wrote:
>> Ext4 doesn't have the ability to punch holes yet, so make sure we return
>> EOPNOTSUPP if we try to use hole punching through fallocate.  This support 
>> can
>> be added later.  Thanks,
>>
>
> Instead of teaching filesystems to fail if they don't support the  
> capability, why don't supporting filesystems say so, allowing the fail  
> code to be in common code?
>

There is no simple way to test if a filesystem supports hole punching or not so
the check has to be done per fs.  Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>