xfs
[Top] [All Lists]

Re: [PATCH, RFC] xfs: fix failed write handling

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH, RFC] xfs: fix failed write handling
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 9 Nov 2010 08:55:20 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20101109113530.GK2715@dastard>
References: <20101109002559.GA30016@xxxxxxxxxxxxx> <20101109055142.GJ2715@dastard> <20101109113530.GK2715@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
> @@ -1020,6 +974,7 @@ out_invalidate:
>       return;
>  }
>  
> +
>  /*
>   * Write out a dirty page.
>   *

Spurious whitespace change.

> +int
> +xfs_bmap_punch_delalloc_range(
> +     struct xfs_inode        *ip,
> +     xfs_fileoff_t           start,
> +     ssize_t                 end)

Making this helper work in terms of FSBs seem a lot cleaner than
making it work in terms of bytes.  Both callers already deal with
FSBs, as does xfs_bunmapi.


Otherwise looks good to me.

<Prev in Thread] Current Thread [Next in Thread>