xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add _require_sparse_files

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add _require_sparse_files
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 9 Nov 2010 23:00:36 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101109113453.GA21237@xxxxxxxxxxxxx>
References: <20101028123414.GA24977@xxxxxxxxxxxxx> <20101109113453.GA21237@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Nov 09, 2010 at 06:34:54AM -0500, Christoph Hellwig wrote:
> updated version to also include test 239 which reqires the check, too.
> 
> ---
> From: Christoph Hellwig <hch@xxxxxx>
> Subject: [PATCH] xfstests: add _require_sparse_files
> 
> Add a helper to check if the filesystem supports sparse files.  This is
> used to guard tests that exercise sparse file functionality and would
> take forever on filesystems that have to zero all blocks on extending
> truncates.
> 
> Unfortunately there's no good way to autodetect this functionality, so
> just implement it as a blacklist for now.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks ok, minor typo needs fixing, but:

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

> +#
> +# Check if the filesystem supports sparese files.
                                      sparse

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>