xfs
[Top] [All Lists]

Re: [PATCH 11/16] xfs: connect up buffer reclaim priority hooks

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/16] xfs: connect up buffer reclaim priority hooks
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 9 Nov 2010 10:50:49 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101108112509.GA7654@xxxxxxxxxxxxx>
References: <1289206519-18377-1-git-send-email-david@xxxxxxxxxxxxx> <1289206519-18377-12-git-send-email-david@xxxxxxxxxxxxx> <20101108112509.GA7654@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Nov 08, 2010 at 06:25:09AM -0500, Christoph Hellwig wrote:
> > +/*
> > + * buffer types 
> > + */
> > +#define    B_FS_DQUOT      1
> > +#define    B_FS_AGFL       2
> > +#define    B_FS_AGF        3
> > +#define    B_FS_ATTR_BTREE 4
> > +#define    B_FS_DIR_BTREE  5
> > +#define    B_FS_MAP        6
> > +#define    B_FS_INOMAP     7
> > +#define    B_FS_AGI        8
> > +#define    B_FS_INO        9
> 
> Is there any good reason to keep/reintroduce the buffer types?  In this
> series we're only using the refcounts, and I can't see any good use for
> the types either.

I just wanted to use the existing hooks without modifying them to be
plain "set reference" hooks. I'm not really fussed - this was just
the simplest way to get the hookѕ working.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>