Re: [PATCH 10/16] xfs: add a lru to the XFS buffer cache

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

> @@ -471,6 +546,8 @@ _xfs_buf_find(
>               /* the buffer keeps the perag reference until it is freed */
>               new_bp->b_pag = pag;
>               spin_unlock(&pag->pag_buf_lock);
> +
> +             xfs_buf_lru_add(new_bp);

Why do we add the buffer to the lru when we find it?  Normally we
would remove it here (unless we want a lazy lru scheme), and potentially
increment b_lru_ref - although that seems to be done by the callers
in the next patch.