xfs
[Top] [All Lists]

Re: [PATCH 08/16] xfs: convert pag_ici_lock to a spin lock

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/16] xfs: convert pag_ici_lock to a spin lock
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 8 Nov 2010 18:10:19 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1289206519-18377-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1289206519-18377-1-git-send-email-david@xxxxxxxxxxxxx> <1289206519-18377-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 08, 2010 at 07:55:11PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> now that we are using RCU protection for the inode cache lookups,
> the lock is only needed on the modification side. Hence it is not
> necessary for the lock to be a rwlock as there are no read side
> holders anymore. Convert it to a spin lock to reflect it's exclusive
> nature.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Alex Elder <aelder@xxxxxxx>

Looks good, and this will make Thomas happy given that XFS is now
rwlock_t-free.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>