Re: [PATCH 02/16] xfs: move delayed write buffer trace

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 02/16] xfs: move delayed write buffer trace
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 8 Nov 2010 04:24:36 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1289206519-18377-3-git-send-email-david@xxxxxxxxxxxxx>
References:	<1289206519-18377-1-git-send-email-david@xxxxxxxxxxxxx> <1289206519-18377-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Nov 08, 2010 at 07:55:05PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The delayed write buffer split trace currently issues a trace for
> every buffer it scans. These buffers are not necessarily queued for
> delayed write. Indeed, when buffers are pinned, there can be
> thousands of traces of buffers that aren't actually queued for
> delayed write and the ones that are are lost in the noise. Move the
> trace point to record only buffers that are split out for IO to be
> issued on.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/16] xfs: current patch stack for 2.6.38 window, Dave Chinner [PATCH 03/16] [RFC] xfs: use generic per-cpu counter infrastructure, Dave Chinner Re: [PATCH 03/16] [RFC] xfs: use generic per-cpu counter infrastructure, Christoph Hellwig Re: [PATCH 03/16] [RFC] xfs: use generic per-cpu counter infrastructure, Dave Chinner [PATCH 02/16] xfs: move delayed write buffer trace, Dave Chinner Re: [PATCH 02/16] xfs: move delayed write buffer trace, Christoph Hellwig <= [PATCH 09/16] xfs: convert xfsbud shrinker to a per-buftarg shrinker., Dave Chinner [PATCH 06/16] patch xfs-inode-hash-fake, Dave Chinner Re: [PATCH 06/16] patch xfs-inode-hash-fake, Christoph Hellwig [PATCH 01/16] xfs: fix per-ag reference counting in inode reclaim tree walking, Dave Chinner Re: [PATCH 01/16] xfs: fix per-ag reference counting in inode reclaim tree walking, Christoph Hellwig [PATCH 04/16] xfs: dynamic speculative EOF preallocation, Dave Chinner Re: [PATCH 04/16] xfs: dynamic speculative EOF preallocation, Christoph Hellwig Re: [PATCH 04/16] xfs: dynamic speculative EOF preallocation, Dave Chinner [PATCH 05/16] xfs: don't truncate prealloc from frequently accessed inodes, Dave Chinner Re: [PATCH 05/16] xfs: don't truncate prealloc from frequently accessed inodes, Christoph Hellwig

Previous by Date:	Re: [PATCH 01/16] xfs: fix per-ag reference counting in inode reclaim tree walking, Christoph Hellwig
Next by Date:	Re: [PATCH 07/18] xfs: don't use vfs writeback for pure metadata modifications, Christoph Hellwig
Previous by Thread:	[PATCH 02/16] xfs: move delayed write buffer trace, Dave Chinner
Next by Thread:	[PATCH 09/16] xfs: convert xfsbud shrinker to a per-buftarg shrinker., Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]