xfs
[Top] [All Lists]

Re: [PATCH 01/16] xfs: fix per-ag reference counting in inode reclaim tr

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/16] xfs: fix per-ag reference counting in inode reclaim tree walking
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 8 Nov 2010 04:23:52 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1289206519-18377-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1289206519-18377-1-git-send-email-david@xxxxxxxxxxxxx> <1289206519-18377-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +++ b/fs/xfs/linux-2.6/xfs_sync.c
> @@ -853,6 +853,7 @@ restart:
>               if (trylock) {
>                       if (!mutex_trylock(&pag->pag_ici_reclaim_lock)) {
>                               skipped++;
> +                             xfs_perag_put(pag);
>                               continue;
>                       }
>                       first_index = pag->pag_ici_reclaim_cursor;

One way to make this loop more maintainable is to split the guts of it
into a xfs_reclaim_inodes_ag helper, and make the existing function a
wrapper around it (and remove the incorrect _ag prefix), but that's .38
material.

For .37 the patch looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>