xfs
[Top] [All Lists]

Re: [PATCH 2/3] xfs: fix a few compiler warnings with CONFIG_XFS_QUOTA=n

To: Andi Kleen <andi@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] xfs: fix a few compiler warnings with CONFIG_XFS_QUOTA=n
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 6 Nov 2010 13:56:31 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <87aalmtk66.fsf@xxxxxxxxxxxxxxxxx>
References: <20101106114226.GA25395@xxxxxxxxxxxxx> <20101106114256.GC25395@xxxxxxxxxxxxx> <87aalmtk66.fsf@xxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Nov 06, 2010 at 06:51:29PM +0100, Andi Kleen wrote:
> Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:
> 
> > Andi Kleen reported that gcc-4.5 gives lots of warnings for him inside the
> > XFS code.  It turned out most of them are due to the quota stubs beeing
> > macros, and gcc now complaining about macros evaluating to 0 that are not
> > assigned to variables.
> 
> Thanks. BTW I believe this was already fixed in my big warning patchkit
> from some time ago, unfortunately that didn't make it in :-/
> 
> A gcc 4.6 build is also still incredibly noisy.

I'll tacked the dir warnings your reported next, and after that I'll
look into more of the gcc 4.6 warnings. But that's 2.6.38 material,
while this one is simple enough to still sneak it into 2.6.37.

<Prev in Thread] Current Thread [Next in Thread>