xfs
[Top] [All Lists]

Re: [PATCH 2/3] xfs: fix a few compiler warnings with CONFIG_XFS_QUOTA=n

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] xfs: fix a few compiler warnings with CONFIG_XFS_QUOTA=n
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Sat, 06 Nov 2010 18:51:29 +0100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101106114256.GC25395@xxxxxxxxxxxxx> (Christoph Hellwig's message of "Sat, 6 Nov 2010 07:42:56 -0400")
References: <20101106114226.GA25395@xxxxxxxxxxxxx> <20101106114256.GC25395@xxxxxxxxxxxxx>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

> Andi Kleen reported that gcc-4.5 gives lots of warnings for him inside the
> XFS code.  It turned out most of them are due to the quota stubs beeing
> macros, and gcc now complaining about macros evaluating to 0 that are not
> assigned to variables.

Thanks. BTW I believe this was already fixed in my big warning patchkit
from some time ago, unfortunately that didn't make it in :-/

A gcc 4.6 build is also still incredibly noisy.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.

<Prev in Thread] Current Thread [Next in Thread>