xfs
[Top] [All Lists]

Re: [PATCH 41/49] fs/xfs: Use vzalloc

To: Joe Perches <joe@xxxxxxxxxxx>
Subject: Re: [PATCH 41/49] fs/xfs: Use vzalloc
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 05 Nov 2010 12:09:45 -0500
Cc: Jiri Kosina <trivial@xxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <10acc19712bf3d1e0ea68e7c16e1723922541249.1288925425.git.joe@xxxxxxxxxxx>
References: <alpine.DEB.2.00.1011031108260.11625@xxxxxxxxxxx> <10acc19712bf3d1e0ea68e7c16e1723922541249.1288925425.git.joe@xxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Thu, 2010-11-04 at 20:08 -0700, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
>  fs/xfs/linux-2.6/kmem.h |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/xfs/linux-2.6/kmem.h b/fs/xfs/linux-2.6/kmem.h
> index f7c8f7a..292eff1 100644
> --- a/fs/xfs/linux-2.6/kmem.h
> +++ b/fs/xfs/linux-2.6/kmem.h
> @@ -61,12 +61,7 @@ extern void  kmem_free(const void *);
>  
>  static inline void *kmem_zalloc_large(size_t size)
>  {
> -     void *ptr;
> -
> -     ptr = vmalloc(size);
> -     if (ptr)
> -             memset(ptr, 0, size);
> -     return ptr;
> +     return vzalloc(size);
>  }
>  static inline void kmem_free_large(void *ptr)
>  {

Looks good to me.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>