[Top] [All Lists]

Re: xfstests: use a common _filter_scratch function

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: xfstests: use a common _filter_scratch function
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 25 Oct 2010 09:44:21 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201010211900.o9LJ086G002762@xxxxxxxxxxxxxxxxxxxxxx>
References: <201010211900.o9LJ086G002762@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 21, 2010 at 02:00:08PM -0500, Alex Elder wrote:
> There are a number of tests that use a shell function called
> "filter_scratch" or "_filter_scratch" in order to have the actual
> scratch device or mount point show up in test output with a symbolic
> name.  There are two sets, each following a slightly different
> convention.  Put a common _filter_scratch function definition in
> "common.filter" and have all test scripts use that instead.
> Choosing one of the two conventions meant that a few test output
> files had to be changed.
> In addition, add a call to _filter_scratch to test 185, and update
> its output accordingly.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>