xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfstests: add _require_attrs

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/4] xfstests: add _require_attrs
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 21 Oct 2010 07:49:34 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101021050202.GA1752@xxxxxxxxxxxxx>
References: <20101015222820.GA3655@xxxxxxxxxxxxx> <20101015222902.GB3781@xxxxxxxxxxxxx> <1287597791.2284.99.camel@doink> <20101021050202.GA1752@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Thu, 2010-10-21 at 01:02 -0400, Christoph Hellwig wrote:
> On Wed, Oct 20, 2010 at 01:03:11PM -0500, Alex Elder wrote:
> > On Fri, 2010-10-15 at 18:29 -0400, Christoph Hellwig wrote:
> > > Add a new helper to check if extended attributes are supported.  It
> > > errors out if any of the attr tools are not found, or if a filesystem
> > > does not support setting attributes.
> > > 
> > > Remove the opencoded checks for the attr tools from various tests
> > > now that we do them in common code.
> > 
> > Generally this looks good.
> > 
> > I was going to just make a few suggestions and ask you
> > to fix them before committing, but  I think there are
> > enough that I think it would be good to re-submit this.
> 
> I'd rather commit the patch as-is and fix up the attr/getfattr
> references separately.  I'll submit a patch to do ASAP.
> 

Sounds good to me.  Probably better that way anyway.    -Alex

<Prev in Thread] Current Thread [Next in Thread>