| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/4] xfstests: handle filesystems without FIEMAP support |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 21 Oct 2010 16:35:29 +1100 |
| Cc: | Alex Elder <aelder@xxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20101021050531.GB1752@xxxxxxxxxxxxx> |
| References: | <20101015222820.GA3655@xxxxxxxxxxxxx> <20101015222924.GD3781@xxxxxxxxxxxxx> <1287596221.2284.97.camel@doink> <20101021050531.GB1752@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Thu, Oct 21, 2010 at 01:05:31AM -0400, Christoph Hellwig wrote:
> On Wed, Oct 20, 2010 at 12:37:01PM -0500, Alex Elder wrote:
> > Looks good, but I think if the operation is not
> > supported you want to delete both "${fiemapfile}"
> > and "${fiemaplog}".
> >
> > While you're at it, make use of the "${fiemapfile}"
> > variable in the fiemap-tester command... (This
> > appears to be a bug in the original test.)
>
> Updated version below:
>
> ---
> From: Christoph Hellwig <hch@xxxxxx>
> Subject: [PATCH 4/4] xfstests: handle filesystems without FIEMAP support
>
> Do a _notrun in 225 if we get EOPNOSUPP back from FIEMAP instead
> of failing the test.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks good.
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfsdocs-xml: fix various formatting errors, Christoph Hellwig |
|---|---|
| Next by Date: | Re: Interesting possible XFS crash condition, Dave Chinner |
| Previous by Thread: | Re: [PATCH 4/4] xfstests: handle filesystems without FIEMAP support, Christoph Hellwig |
| Next by Thread: | Virus Detected, Virus |
| Indexes: | [Date] [Thread] [Top] [All Lists] |