| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: Fix some file permission. |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Sun, 10 Oct 2010 10:12:26 -0500 |
| Cc: | Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Alain Renaud <arenaud@xxxxxxx> |
| In-reply-to: | <20101010080502.GA6674@xxxxxxxxxxxxx> |
| References: | <4CAE483F.1020608@xxxxxxx> <1286660111.5392.6.camel@doink> <20101010015723.GM4681@dastard> <20101010080502.GA6674@xxxxxxxxxxxxx> |
| Reply-to: | aelder@xxxxxxx |
On Sun, 2010-10-10 at 04:05 -0400, Christoph Hellwig wrote: > On Sun, Oct 10, 2010 at 12:57:23PM +1100, Dave Chinner wrote: > > > This looks good to me but I'd like a second opinion, > > > to make sure there's no reason any of these should > > > be non-executable. > > > > I don't think it matters. Consistency is good, though, and we've > > taken patches like this in the past. > > Yeah. Btw, I'm not sure git-am can apply the mode changes from a patch, > in the worst case you might have to do the chmod calls manually. > OK. I'll figure out how to apply it. Thanks. -Alex |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfstests: Fix some file permission., Christoph Hellwig |
|---|---|
| Next by Date: | Re: kernel crash 2.6.31.14-0.1-xen from openSUSE 11.2, Michael Monnerie |
| Previous by Thread: | Re: [PATCH] xfstests: Fix some file permission., Christoph Hellwig |
| Next by Thread: | Re: [PATCH] xfstests: Fix some file permission., Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |