[Top] [All Lists]

Re: [PATCH] xfstests: Fix some file permission.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Fix some file permission.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 10 Oct 2010 04:05:02 -0400
Cc: Alex Elder <aelder@xxxxxxx>, xfs@xxxxxxxxxxx, Alain Renaud <arenaud@xxxxxxx>
In-reply-to: <20101010015723.GM4681@dastard>
References: <4CAE483F.1020608@xxxxxxx> <1286660111.5392.6.camel@doink> <20101010015723.GM4681@dastard>
User-agent: Mutt/1.5.20 (2009-08-17)
On Sun, Oct 10, 2010 at 12:57:23PM +1100, Dave Chinner wrote:
> > This looks good to me but I'd like a second opinion,
> > to make sure there's no reason any of these should
> > be non-executable.
> I don't think it matters. Consistency is good, though, and we've
> taken patches like this in the past.

Yeah.  Btw, I'm not sure git-am can apply the mode changes from a patch,
in the worst case you might have to do the chmod calls manually.

<Prev in Thread] Current Thread [Next in Thread>