[Top] [All Lists]

Re: [PATCH] xfstests: Fix some file permission.

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfstests: Fix some file permission.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 10 Oct 2010 12:57:23 +1100
Cc: Alain Renaud <arenaud@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1286660111.5392.6.camel@doink>
References: <4CAE483F.1020608@xxxxxxx> <1286660111.5392.6.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sat, Oct 09, 2010 at 04:35:11PM -0500, Alex Elder wrote:
> On Thu, 2010-10-07 at 17:22 -0500, Alain Renaud wrote:
> > I notice that some of the test script do not have execute
> > permission. To be consistent I changed the permissions to be 755.
> > Can someone verify that this is valid.
> > 
> > Thanks.
> This looks good to me but I'd like a second opinion,
> to make sure there's no reason any of these should
> be non-executable.

I don't think it matters. Consistency is good, though, and we've
taken patches like this in the past.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>