xfs
[Top] [All Lists]

Re: [PATCH VER 8] xfsprogs: projid32bit handling

To: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>
Subject: Re: [PATCH VER 8] xfsprogs: projid32bit handling
From: Alex Elder <aelder@xxxxxxx>
Date: Sat, 09 Oct 2010 16:33:18 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1286179438-18282-1-git-send-email-arekm@xxxxxxxx>
References: <1286179438-18282-1-git-send-email-arekm@xxxxxxxx>
Reply-to: aelder@xxxxxxx
On Mon, 2010-10-04 at 10:03 +0200, Arkadiusz Miśkiewicz wrote:
> Add projid32bit handling to userspace. mkfs.xfs is able to enable this
> feature for new filesystems. xfs_db knows what projid_lo/hi are.
> 
> Signed-off-by: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>

This looks good.  I tested it with your update for xfstests
and my earlier concerns seem to have been addressed.

I've already committed this change, I just wanted to
make sure you knew it's (finally) in.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> ---
> 
> version 7 news:
> - xfs_admin can now easily enable projid32bit support
> 
> version 8 news:
> - xfs_logprint now prints single 32bit projid instead of two
>   16bit projid_{lo,hi}. Thus we get the same output format
>   as before.
> - use %u for displaying projid (instead of %d)
> - projid32bit flag in mkfs.xfs output separated by coma
> - bs_projid is back as bs_projid_lo + define for compatibility
> - man page formatting fix
> 
>  db/check.c               |    2 +-
>  db/inode.c               |    6 ++++--
>  db/sb.c                  |    6 ++++++
>  db/xfs_admin.sh          |    5 +++--
>  include/xfs_dinode.h     |    5 +++--
>  include/xfs_fs.h         |   17 +++++++++++++++--
>  include/xfs_inode.h      |   25 ++++++++++++++++++++++---
>  include/xfs_sb.h         |   17 ++++++++++++++++-

<Prev in Thread] Current Thread [Next in Thread>